Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error: FirebaseError: Response is not valid JSON object. #877

Open
kachick opened this issue Jun 22, 2023 · 2 comments
Open

error: FirebaseError: Response is not valid JSON object. #877

kachick opened this issue Jun 22, 2023 · 2 comments
Labels
bug javascript Pull requests that update Javascript code

Comments

@kachick
Copy link
Collaborator

kachick commented Jun 22, 2023

It looks intentional, but it makes confusion except the author.
One of the reason is ... these comments appears in code multiple times.
Would it be better when adding notes which code will relate to the current console error.

} catch (e) {
// FIXME:
// currently cloud functions doesn't return appropriate response
// that fits httpsCallable protocol even if the function succeeded.
console.log("error:", e);

} catch (e) {
// FIXME:
// currently cloud functions doesn't return appropriate response
// that fits httpsCallable protocol even if the function succeeded.
console.log("error:", e);
}

} catch (e) {
// FIXME:
// currently cloud functions doesn't return appropriate response
// that fits httpsCallable protocol even if the function succeeded.
console.log("error:", e);
}

} catch (e) {
// FIXME:
// currently cloud functions doesn't return appropriate response
// that fits httpsCallable protocol even if the function succeeded.
console.log("error:", e);
}

@kachick kachick added the javascript Pull requests that update Javascript code label Jun 22, 2023
@kachick
Copy link
Collaborator Author

kachick commented Jun 22, 2023

Original problem is not yet resolved

@kachick kachick reopened this Jun 22, 2023
@kachick kachick changed the title Unkind console log error: FirebaseError: Response is not valid JSON object. error: FirebaseError: Response is not valid JSON object. Jun 22, 2023
@kachick kachick added the bug label Jun 22, 2023
kachick added a commit that referenced this issue Jun 22, 2023
When I addressing #877, I found these use are different from https://firebase.google.com/docs/web/setup?hl=ja
Looks not effect than before change, but this would be better...
@kachick
Copy link
Collaborator Author

kachick commented Jun 22, 2023

I suspect that backend does not correctly return JSON object... 🤔

https://github.com/pankona/hashira/blob/fec942f373cfa12c63c6af4c275e1f2c3c169b9e/hashira-web/functions/func.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug javascript Pull requests that update Javascript code
Projects
None yet
Development

No branches or pull requests

1 participant