Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge packages #53

Open
3 tasks
esteblock opened this issue Oct 19, 2023 · 2 comments
Open
3 tasks

Merge packages #53

esteblock opened this issue Oct 19, 2023 · 2 comments
Labels
enhancement New feature or request
Milestone
2.5: Code Quality...

Comments

@esteblock
Copy link
Member

Currently we have too any packages.
Do we need as many?
And why?

  • Analize the current situation and see what is the problem of having so many packages
  • Choose and justify what are the packages we need
  • Merge
@benjaminsalon
Copy link
Collaborator

One of the issue possibly brought by having different packages is a more difficult local testing environment with Multichain Dapp for example. As every package depend on each other and are all by default linked to the published version of the library, changing one package locally might not change the other one's dependency.
Also it may take more time and redundant copies of the packages when adding the packages to one project.

@esteblock esteblock added the enhancement New feature or request label Oct 30, 2023
@esteblock esteblock moved this from Next to Todo in @soroban-react & Boilerplate Oct 30, 2023
@esteblock
Copy link
Member Author

We can leave 1 package per wallet, and all the other packages should be all merged in core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
@soroban-react & Boilerplate
Status: Todo
Milestone
2.5: Code Quality Enhancement
Development

No branches or pull requests
2 participants
@esteblock @benjaminsalon