Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Flask-SQLAlchemy-Lite datastore #994

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Conversation

jwag956
Copy link
Collaborator

@jwag956 jwag956 commented Jul 3, 2024

  • This introduces new pre-configured models that use 'modern' sqlalchemy type annotations
  • The querying is done using the 2.0 select() mechanism (rather than the old query interface)
  • Enhance view_scaffold test harness to work with either Flask-SQLAlchemy or Flask-SQLAlchemy-Lite
  • FS-Lite requires newer Flask/Werkzeug - bump up lowest tested versions
  • per sqlalchemy best practice - don't install mypy extension or stubs

close #989

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.49%. Comparing base (ec70c1d) to head (5f07f1c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
+ Coverage   98.45%   98.49%   +0.03%     
==========================================
  Files          36       37       +1     
  Lines        4665     4777     +112     
==========================================
+ Hits         4593     4705     +112     
  Misses         72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- This introduces new pre-configured models that use 'modern' sqlalchemy type annotations
- The querying is done using the 2.0 select() mechanism (rather than the old query interface)
- Enhance view_scaffold test harness to work with either Flask-SQLAlchemy or Flask-SQLAlchemy-Lite
- FS-Lite requires newer Flask/Werkzeug - bump up lowest tested versions
- per sqlalchemy best practice - don't install mypy extension or stubs

close #989
@jwag956 jwag956 merged commit 25ad68d into master Jul 3, 2024
20 checks passed
@jwag956 jwag956 deleted the fsqlalite1 branch July 3, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add datastore support for new flask-sqlalchemy-lite
1 participant