Use 'modern' query for all sqlalchemy datastores #1007
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using the model.query and convert to select(xx).where(yy) as recommended in sqlalchemy 2. All 3 sqlalchemy based datastores now share a common implementation.
the sqlalchemy_session datastore tests now use the new sqla models.
Update docs to note that using FsModels.sqla requires pythin 3.10 or higher.
To simplify code - the find_user() method now takes a single kwarg (attribute:value) for selecting - that is all FS ever used so supporting multiple added complexity.
Added a new low-level way to capture queries during unit tests - converted all tests to use that.