Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-evaluate policy when PR base branch changes #818

Open
bluekeyes opened this issue Aug 9, 2024 · 0 comments
Open

Re-evaluate policy when PR base branch changes #818

bluekeyes opened this issue Aug 9, 2024 · 0 comments

Comments

@bluekeyes
Copy link
Member

bluekeyes commented Aug 9, 2024

If a PR's base branch changes, the policy-bot check context will have a different value and the policy may have different rules, but it looks like we don't respond to this webhook event. This means users must take some action (add a comment, push a commit, visit the details page) to post the updated status check.

While we do handle the edited action in the pull_request event, I have a feeling that trigger value is leading to skipped evalutation for some policies:

case "edited":
t = common.TriggerPullRequest

We probably need to always use a different trigger or change the trigger based on what was edited about the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant