From b5eb5619a08e3c067f7f398c7825a34bf4891798 Mon Sep 17 00:00:00 2001
From: Billy Keyes <bkeyes@palantir.com>
Date: Mon, 24 Jun 2019 16:34:20 -0700
Subject: [PATCH] Increase the number of retries for missing dates (#92)

Internally, the existing timeouts are not always sufficient. Adjust the
retry loop to use exponential backoff with more attempts, resulting in a
total of 15s between the first and last attempts instead of the 3s in
the old implementation. Note that GitHub hooks have a 30s timeout, so we
can't go too much higher on the retry counts.
---
 pull/github.go | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/pull/github.go b/pull/github.go
index c012f91b..cabd2363 100644
--- a/pull/github.go
+++ b/pull/github.go
@@ -36,8 +36,9 @@ const (
 )
 
 var (
-	commitLoadMaxAttempts = 3
-	commitLoadBaseDelay   = time.Second
+	// 5 attempts, exponential 1000ms delay = 15s max wait
+	commitLoadMaxAttempts = 5
+	commitLoadBaseDelay   = 1000 * time.Millisecond
 )
 
 // Locator identifies a pull request and optionally contains a full or partial
@@ -357,7 +358,7 @@ func (ghc *GitHubContext) loadCommits() ([]*Commit, error) {
 		if attempts >= commitLoadMaxAttempts {
 			return nil, errors.Errorf("head commit %.10s is missing pushed date; this is probably a bug", ghc.pr.HeadRefOID)
 		}
-		time.Sleep(time.Duration(attempts) * commitLoadBaseDelay)
+		time.Sleep(time.Duration(1<<uint(attempts-1)) * commitLoadBaseDelay)
 	}
 }