Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Hyper and Rustls in Pact Rust mock server #414

Open
rholshausen opened this issue May 7, 2024 · 1 comment
Open

Upgrade Hyper and Rustls in Pact Rust mock server #414

rholshausen opened this issue May 7, 2024 · 1 comment
Labels
enhancement Indicates new feature requests smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear

Comments

@rholshausen
Copy link
Contributor

Current Hyper is locked to 0.14.x, Rustls to 0.24.x and tokio-rustls to 0.24.x. To upgrade the TLS crates seems to need Hyper to be upgraded to 1.0+.

The current mock server implementation was written in 2017-2019, and contains some esoteric TLS code that may be more complex to upgrade to Hyper 1.0 than to rewrite it using newer Hyper 1.0 constructs.

Upgrading to Hyper 1.0 will also give the following benefits:

  • Supports both HTTP 1 and 2 with the same server implementation
  • Supports protocol upgrades (leading to supporting things like Web Sockets)
  • Middleware support
  • No more need for the custom TLS code

A suggestion is to split this component out into it's own repository, so that we can easily support a 1.0.x version as well as a 2.0.x version using branches.

@rholshausen rholshausen added enhancement Indicates new feature requests smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear labels May 7, 2024
Copy link

github-actions bot commented May 7, 2024

🤖 Great news! We've labeled this issue as smartbear-supported and created a tracking ticket in PactFlow's Jira (PACT-1973). We'll keep work public and post updates here. Meanwhile, feel free to check out our docs. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates new feature requests smartbear-supported SmartBear engineering team will support this issue. See https://docs.pact.io/help/smartbear
Projects
None yet
Development

No branches or pull requests

1 participant