Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OpenScanHub URLs & ensured TypeScript compliance #485

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

Venefilyn
Copy link
Collaborator

There were some stuff missing regarding styling of the API and what went
on within components. In particular a lot of additions that were not
changed after copying from another component.

As for the API interfaces they were missing the submitted_time which
showed errors within the components themselves.

Also URLs and titles have been renamed to indicate OpenScanHub more
explicitly as we do not have to use abbreviations.

RELEASE NOTES BEGIN
Rename OpenScanHub URLs and improved styling
RELEASE NOTES END

There were some stuff missing regarding styling of the API and what went
on within components. In particular a lot of additions that were not
changed after copying from another component.

As for the API interfaces they were missing the submitted_time which
showed errors within the components themselves.

Also URLs and titles have been renamed to indicate OpenScanHub more
explicitly as we do not have to use abbreviations.
Copy link
Contributor

Copy link
Member

@lbarcziova lbarcziova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the improvements!

@Venefilyn Venefilyn added this pull request to the merge queue Nov 11, 2024
Merged via the queue into packit:main with commit adff891 Nov 11, 2024
3 of 4 checks passed
@Venefilyn Venefilyn deleted the fix/osh-bugs-and-styling branch November 11, 2024 16:32
softwarefactory-project-zuul bot added a commit to packit/packit.dev that referenced this pull request Nov 12, 2024
chore(weekly): add blog for 45th week of 2024

Should I wait for packit/dashboard#485 and include it?
Closes #674

Reviewed-by: Laura Barcziová
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants