Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pending icon for pending states #460

Closed
2 tasks
QuLogic opened this issue Oct 1, 2024 · 2 comments · Fixed by #463
Closed
2 tasks

Use pending icon for pending states #460

QuLogic opened this issue Oct 1, 2024 · 2 comments · Fixed by #463
Labels
area/other Related to some other area/category than the specified ones. area/user-experience Usability issue complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users.

Comments

@QuLogic
Copy link

QuLogic commented Oct 1, 2024

Description

Currently if a job is in progress, it has a sort of "i" icon:
image
This looks very similar to the error icon:
image
Both appear as bold vertical bars, with maybe a pixel gap somewhere.

As neither of these actually directly display the state directly (you need to hover to get the tooltip), and the only other differentiation is the colour, it's difficult to realize the difference between them.

It would perhaps be better to use the pficon-pending or pficon-in-progress icons, as in:
https://www.patternfly.org/components/progress-stepper/#with-custom-icons

Benefit

Clearer differentiation between job states.

Importance

No response

Workaround

  • There is an existing workaround that can be used until this feature is implemented.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@lbarcziova lbarcziova added area/user-experience Usability issue area/other Related to some other area/category than the specified ones. complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. labels Oct 1, 2024
@lbarcziova lbarcziova moved this from new to priority-backlog in Packit Kanban Board Oct 1, 2024
@Venefilyn
Copy link
Collaborator

I agree this would be a great thing to change as they're very similar. I'll get a PR up today to fix it if possible! Pending icon could work, I'll double-check with other icons too but leaning on this one

@mfocko
Copy link
Member

mfocko commented Oct 1, 2024

@kapr200 is looking into the issue currently, review will be appreciated though :)

kapr200 added a commit to kapr200/dashboard that referenced this issue Oct 1, 2024
New colors and icons for:
* running
* pending
* skipped

Fixes packit#460
kapr200 added a commit to kapr200/dashboard that referenced this issue Oct 1, 2024
New colors and icons for:
* running
* pending
* skipped

Fixes packit#460
github-merge-queue bot pushed a commit that referenced this issue Oct 1, 2024
New colors and icons for:
* running
* pending
* skipped

Fixes #460
@github-project-automation github-project-automation bot moved this from priority-backlog to done in Packit Kanban Board Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/other Related to some other area/category than the specified ones. area/user-experience Usability issue complexity/easy-fix No planning/thinking about design needed, should be finished in an hour. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants