Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to pull request if I have lots of commit ? #429

Closed
bansan85 opened this issue Jun 25, 2024 · 2 comments
Closed

How to pull request if I have lots of commit ? #429

bansan85 opened this issue Jun 25, 2024 · 2 comments

Comments

@bansan85
Copy link

@paceholder

I worked on nodeeditor half an year ago. I fixed lots of tiny thing, I added a (buggy) QML wrapper but it's a good start. I also added some examples. I also changed the algorithm to draw line connection to avoid overlapping with boxes.

How do you like I send you MR ? One for each commit ? A big MR with lots of commit and you review them one by one ?

@bansan85 bansan85 changed the title How to pull request if I have lots of commit How to pull request if I have lots of commit ? Jun 25, 2024
@paceholder
Copy link
Owner

Hello!

Sorry for mu belated response -- many things to do besides this project.
I'd prefer splitting the PRs by topic.

Regards,
Dimitry

@bansan85
Copy link
Author

OK. After few hours, I successfully isolated the qml part. I also added few example.

It's difficult for me to split every topic because I made changes in one time without thinking about merging them properly.

@bansan85 bansan85 mentioned this issue Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants