Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Python >=3.11 #466

Open
mhechthz opened this issue Dec 30, 2023 · 6 comments
Open

Not compatible with Python >=3.11 #466

mhechthz opened this issue Dec 30, 2023 · 6 comments

Comments

@mhechthz
Copy link

On windows the library is not compatible with Python 3.11 since Pillow 9.0.x is not compatible with Python 3.11. Compilation is needed which is never a good idea since it failes on most systems. Python 3.10 works well but is outdated now.

Copy link
Contributor

Thank you for submitting your first issue to p5py

@Gyan313
Copy link

Gyan313 commented Jan 1, 2024

@mhechthz can we not change Pillow to its latest version 10.1.0 which is compatible with python 3.11 ? It worked for me so thats why I am suggesting. And if there is any issue with that let me know as I am new to open Source ✌️.

@mhechthz
Copy link
Author

mhechthz commented Jan 1, 2024

Yes @Gyan313, this is exactly what I would like to be changed. So I can directly install the library using pip instead of compiling it on my own machine during installation (which never works on many windows machines and for many colleagues I know).

@tushar5526
Copy link
Member

Thanks, @mhechthz @Gyan313 for testing it out on windows. I should probably add a basic GHA for windows that installs the p5 on it. Would any of you like to make a PR to bump the Pillow dependency?

@Gyan313
Copy link

Gyan313 commented Jan 3, 2024

@tushar5526 Hi, I'm also working on integrating a pre-commit hook to p5, and I'm currently addressing some flake8 issues. Once I'm finished, I'll submit a pull request to update the Pillow dependency. Whether or not I resolve the flake8 problem, I'll still create a PR for Pillow today. ✌️❤️

@tushar5526
Copy link
Member

Hey @Gyan313 awesome to hear about your plans! Just a heads-up on something related to pre-commit already in the pipeline - #460

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants