Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update progress percentage UI in accordance with w3up-client #52

Open
akhileshthite opened this issue Feb 5, 2024 · 0 comments
Open

feat: update progress percentage UI in accordance with w3up-client #52

akhileshthite opened this issue Feb 5, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@akhileshthite
Copy link
Member

akhileshthite commented Feb 5, 2024 •
edited
Loading

Use onShardStored option in uploadFile and uploadDirectory.

See how it gets used in the w3cli here:
https://github.com/web3-storage/w3cli/blob/55f546be85e321b00ddd18c8ded277935eedebde/index.js#L129C5-L129C18

See how the progress percentage UI was implemented previously in web3storage script:
Files:

dscan/src/scripts/web3Storage.js

Line 20 in b01101a

onStoredChunk: getProgressUpdater(files),

Folder:

dscan/src/scripts/web3Storage.js

Line 50 in b01101a

onStoredChunk: getProgressUpdater(updatedFiles),

159699899-44d83e3b-03e1-4cb3-bbcc-99679497ebe8
@akhileshthite akhileshthite added enhancement New feature or request good first issue Good for newcomers labels Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akhileshthite