-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match react native API #3
Comments
I've been chatting with @oyyd about this and have started some work to make react-yue more close to react-native, see #4. He seems on board with the idea and I will be continuing to submit PRs to help get it closer to that point. The question regarding whether or not to rename the element names to match react native has some pros and cons. Pros being the ease with which someone coming from react native could jump into react-yue. The cons being that if someone needed to look at |
Like what @shichongrui said, We still need to learn a lot from |
I see your point @oyyd. Since yue is an evolution of electron and already depends on yoga for layout, I wonder, would it be desirable to have these changes (inlcuding what @shichongrui implemented on #4 which is great btw! :D) upstream instead @zcbenz? |
Currently, I would like the merge #4. I'm not familiar with react native and I think this needs more discussion and investigation. It would be better if we could come out with a detailed plan. |
Hi,
Would you be interested in a PR matching react native's API where possible?
Off the top of my head it would be:
container
->View
scroll
->ScrollView
label
->Text
entry
/textedit
->TextInput
with certain props remapped, eg:
would be:
Is that aligned with where you want to take this library?
Thanks!
Darío
The text was updated successfully, but these errors were encountered: