From 9b152a4150071bbf4ad6d9e6c4e472ea507bd9d2 Mon Sep 17 00:00:00 2001 From: Audric Ackermann Date: Wed, 18 Sep 2024 11:58:09 +1000 Subject: [PATCH] fix: validate strings after uploading artefacts so that it's easier to debug --- .github/workflows/check_for_crowdin_updates.yml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/workflows/check_for_crowdin_updates.yml b/.github/workflows/check_for_crowdin_updates.yml index 5b4b03f..8c975fd 100644 --- a/.github/workflows/check_for_crowdin_updates.yml +++ b/.github/workflows/check_for_crowdin_updates.yml @@ -64,11 +64,6 @@ jobs: "${{ github.workspace }}/raw_translations" \ "${{ github.workspace }}/desktop/_locales" \ "${{ github.workspace }}/desktop/ts/localization/constants.ts" - - name: Prepare QA strings - run: | - cd ${{ github.workspace }}/desktop/ - python ./tools/localization/generateLocales.py --generate-types --print-problems --print-problem-strings --print-problem-formatting-tag-strings --error-on-problems - cd - - name: Prepare iOS Strings run: | python "${{ github.workspace }}/scripts/crowdin/generate_ios_strings.py" \ @@ -106,6 +101,13 @@ jobs: overwrite: true if-no-files-found: warn retention-days: 7 + # It's easier to find what went wrong with some strings if we can get the files from the artefact upload step above. + # The job will still be marked as failed and no Pull Requests will be made. + - name: Prepare QA strings + run: | + cd ${{ github.workspace }}/desktop/ + python ./tools/localization/generateLocales.py --generate-types --print-problems --print-problem-strings --print-problem-formatting-tag-strings --error-on-problems + cd - - name: Upload QA artefacts uses: actions/upload-artifact@v4 with: @@ -117,6 +119,8 @@ jobs: if-no-files-found: warn retention-days: 7 + + # Not sure why yet, but uploading artefacts after creating the pull requests # seems to only include a part of what should be in. # As a dirty fix we upload the artefacts first, and then make the pull request