Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maintenance page #339

Open
wkloucek opened this issue Jun 28, 2023 · 3 comments
Open

add maintenance page #339

wkloucek opened this issue Jun 28, 2023 · 3 comments
Labels
Category:Enhancement Add new functionality Category:Technical Technical ehancements Type:Discussion

Comments

@wkloucek
Copy link
Contributor

We could use a Helm pre-upgrade hook to change the ingress to respond with a static maintenance page. This maintenance page would respond to all api routes. It would need respond with 503 Service Unavailable or a similar status code, so that the clients don't error.

During the Helm post-upgrade hook, we would then need to switch back to the regular ingress.

One challenge would be to not interrupt requests when going into maintenance mode. This can be challenging especially for slow / big uploads (=long running requests).

@wkloucek wkloucek added Category:Enhancement Add new functionality Category:Technical Technical ehancements Type:Discussion labels Jun 28, 2023
@wkloucek
Copy link
Contributor Author

@d7oc do you have an opinion on this? Currently, while services are restarting (eg. when having DeploymentStrategy Recreate) the behaviour of oCIS is undefined (eg. 401 / 500 errors can appear). Therefore I would prefer having a maintenance page.

@d7oc
Copy link
Contributor

d7oc commented Jun 29, 2023

To me it sounds like we should fix the undefined state. There should be no point in time when a user sees different errors. The liveness and readiness checks should ensure that once a user reaches a service it should be up and running. After that there should be only 503 from the service itself as long as there are no pod detected as live and ready. For that I would go with a solution like the one here https://devops.stackexchange.com/a/13637 and make the ingress return a specific page in case of 503.

@wkloucek
Copy link
Contributor Author

Discussion on Web: owncloud/web#10260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality Category:Technical Technical ehancements Type:Discussion
Projects
None yet
Development

No branches or pull requests

2 participants