Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete database.xml and replace with migration #167

Open
PVince81 opened this issue Oct 13, 2018 · 3 comments
Open

Delete database.xml and replace with migration #167

PVince81 opened this issue Oct 13, 2018 · 3 comments

Comments

@PVince81
Copy link
Contributor

Similar to owncloud/activity#652

The hybrid approach of database.xml + migrations can have update scenarios in which changes made in database.xml between the current version and the version that introduces migrations are not done.

@DeepDiver1975 can you verify ?
@PVince81
Copy link
Contributor Author

migrations were introduced in v0.2.0 here 4da13c2

@PVince81
Copy link
Contributor Author

we should also get rid of database.xml because there is a risk of people adding stuff there without adding a matching migration

@PVince81
Copy link
Contributor Author

I've checked the version history and there were no changes in database.xml after v0.2.0 where migrations were introduced, so we're safe.

Keeping this ticket for deleting database.xml and having a migration that creates the tables.

@PVince81 PVince81 changed the title Potentially missing DB changes Delete database.xml and replace with migration Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PVince81