Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors in the Nextcloud log when using the Subsonic XML API on NC28 #1142

Closed
Anvil5465 opened this issue Apr 8, 2024 · 3 comments
Closed

Errors in the Nextcloud log when using the Subsonic XML API on NC28 #1142

Anvil5465 opened this issue Apr 8, 2024 · 3 comments
Labels
6 - Ready for release Fix or feature is ready and will be included in the next release Bug

Comments

@Anvil5465
Copy link

I get thousands of error messages per week in the log when using the Amperfy client.

See BLeeEZ/amperfy#233 (comment)
@paulijar
Copy link
Collaborator

paulijar commented Apr 8, 2024

Thanks for the report. This looks very similar to the issue #1139. In that case, the client is making a slightly incorrect request, but I now tested and it seems to be irrelevant for the case. For me, this seems to happen on each Subsonic API call on NC28.0.2 but not on NC27.1.2. Apparently Nextcloud has changed something and I need to adapt.

@paulijar paulijar added the Bug label Apr 8, 2024
@paulijar paulijar mentioned this issue Apr 8, 2024
Closed
@paulijar paulijar changed the title Errors thrown in the Nextcloud log when using Amperfy with Nextcloud Music via Subsonic Errors in the Nextcloud log when using the Subsonic API on NC28 Apr 8, 2024
@paulijar paulijar changed the title Errors in the Nextcloud log when using the Subsonic API on NC28 Errors in the Nextcloud log when using the Subsonic XML API on NC28 Apr 8, 2024
paulijar added a commit that referenced this issue Apr 8, 2024
@paulijar
Fix every Subsonic XML API call logging an error on NC28+
1f20182 
Every call to the Subsonic XML API caused and error 'Undefined array
key "" at /var/www/html/lib/private/AppFramework/Http.php#128' to be
logged to the nextcloud.log.

This happened because the XmlResponse object had no response status
set. Setting this used to happen automatically, but after the Nextcloud
PR nextcloud/server#38802, the automatic setting
has not happened without a call to the parent class constructor from
the derived class. However, we can't call the parent constructor because
it doesn't exist on ownCloud. To overcome the problem, we now set the
status code explicitly in the constructor of XmlResponse.

refs #1142
@paulijar paulijar added the 6 - Ready for release Fix or feature is ready and will be included in the next release label Apr 8, 2024
@paulijar
Copy link
Collaborator

paulijar commented Apr 8, 2024

Further investigation revealed that this happened when calling the Subsonic XML API but not with the JSON API. The culprit seems to be the Nextcloud PR nextcloud/server#38802 which changed the behavior of the Response base class. Should be fixed now and the fix will be released in Music 1.11.0 which is planned to ship before NC 29 is released.

@paulijar
Copy link
Collaborator

The fix is now released in Music v1.11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6 - Ready for release Fix or feature is ready and will be included in the next release Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulijar @Anvil5465