Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't spray XML parser errors to stderr #2930

Open
wants to merge 1 commit into
base: v2/master
Choose a base branch
from

Conversation

erkia
Copy link

@erkia erkia commented Jul 17, 2023

Currently, all XML parser errors are written to stderr, which in case of Apache means that the messages end up randomly in error_log, unformatted.

This pull request adds custom XML error handling function, which just discards all the messages at the moment.

@martinhsv
Copy link
Contributor

Hello @erkia ,

Could you provide a couple of examples of such messages? Ideally include xml bodies to reproduce them and whether any special configuration is required to reproduce the issue (e.g. higher LogLevel in the apache config).

@martinhsv martinhsv added the 2.x Related to ModSecurity version 2.x label Oct 17, 2023
@marcstern
Copy link
Contributor

Non-standard messages in error log are not clean, but no message at all isn't good either.
We should use msr_log(msr, ...), no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Related to ModSecurity version 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants