Avro-ts using namespace instead of name to describe wrapped unions

[puzzledbytheweb]

Hey!

We are implementing the changes to support the Reader Schema in our code but we're stuck. Comparing the schema that we got from Aiven with the generated types, it looks like the type for the event uses the namespace (instead of the name) to differ between the different branches in the union.

export interface Event {
   event:
     | {
         'namespace.obfuscated.this.is.a.public.package.event.CreatedOrUpdate': NAMESPACE.CreatedOrUpdate;
         'namespace.obfuscated.this.is.a.public.package.event.Deleted'?: never;
       }
     | {
         'namespace.obfuscated.this.is.a.public.package.event.CreatedOrUpdate'?: never;
         'namespace.obfuscated.this.is.a.public.package.event.Deleted': NAMESPACE.Deleted;
       };
 }

{
   "name": "event",
   "type": [
        {
              "type": "record",
              "name": "CreatedOrUpdate",
              "namespace": "different.namespace.obfuscated.this.is.a.public.package.Event",
              "fields": ["MANY_FIELDS"]
        },
        {
              "type": "record",
              "name": "Deleted",
              "namespace": "different.namespace.obfuscated.this.is.a.public.package.Event",
              "fields": ["JUST_AN_ID"]
       }
   ]
}

You can notice that if the generated types used the name, if the namespace changed, everything would be fine. But because it is using the namespace (concatenated with the name), if a message is produced with a different namespace we'll never be able to access the correct branch of the union.

[ivank]

This seems to be a deeper problem from avsc library. Opened an issue there, lets see if they can resolve it first mtth/avsc#361