Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement access_token auth method #83

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

0x416e746f6e
Copy link
Contributor

subj.

this PR is a part 1 for issue ovh/terraform-provider-ovh#660

cc: @amstuta

@deathiop
Copy link
Contributor

Hello,

Thank you for this implementation!
As per our contributing guide, we require commits to be signed-off. Could you please amend yours? (git commit --amend --no-edit -s would do the trick)

@0x416e746f6e
Copy link
Contributor Author

Hello,

Thank you for this implementation! As per our contributing guide, we require commits to be signed-off. Could you please amend yours? (git commit --amend --no-edit -s would do the trick)

hi @deathiop, but my commit is already signed:

image

or am I missing something?

@0x416e746f6e
Copy link
Contributor Author

ah, ok. I see what you mean.

fixed!

Copy link
Contributor

@amstuta amstuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution :)

Could you also add a section in https://github.com/ovh/go-ovh?tab=readme-ov-file#configuration to describe this new auth method ?

ovh/configuration.go Outdated Show resolved Hide resolved
Co-authored-by: Arthur Amstutz <[email protected]>
Signed-off-by: Anton Bronnikov <[email protected]>
@0x416e746f6e
Copy link
Contributor Author

Could you also add a section in https://github.com/ovh/go-ovh?tab=readme-ov-file#configuration to describe this new auth method ?

@amstuta please have a look.

ovh/configuration_test.go Outdated Show resolved Hide resolved
Signed-off-by: Anton Bronnikov <[email protected]>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Anton Bronnikov <[email protected]>

Co-authored-by: Adrien Barreau <[email protected]>
Signed-off-by: Anton Bronnikov <[email protected]>
@amstuta amstuta merged commit 6817886 into ovh:master Jun 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants