-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement access_token
auth method
#83
Conversation
Hello, Thank you for this implementation! |
hi @deathiop, but my commit is already signed: or am I missing something? |
Signed-off-by: Anton Bronnikov <[email protected]>
4df4e51
to
620f009
Compare
ah, ok. I see what you mean. fixed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution :)
Could you also add a section in https://github.com/ovh/go-ovh?tab=readme-ov-file#configuration to describe this new auth method ?
Co-authored-by: Arthur Amstutz <[email protected]> Signed-off-by: Anton Bronnikov <[email protected]>
bdeadc4
to
a534dff
Compare
Signed-off-by: Anton Bronnikov <[email protected]>
2dbc9da
to
c0bfeaf
Compare
@amstuta please have a look. |
Signed-off-by: Anton Bronnikov <[email protected]>
Signed-off-by: Anton Bronnikov <[email protected]> Co-authored-by: Adrien Barreau <[email protected]> Signed-off-by: Anton Bronnikov <[email protected]>
bb2d05a
to
bff1e65
Compare
subj.
this PR is a part 1 for issue ovh/terraform-provider-ovh#660
cc: @amstuta