Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hpc - VCD migration guide update and fix #6884

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Hpc - VCD migration guide update and fix #6884

merged 8 commits into from
Sep 25, 2024

Conversation

pg-ovh
Copy link
Contributor

@pg-ovh pg-ovh commented Sep 17, 2024

Guide fix and updates.

@pg-ovh pg-ovh added Update request FIX The Pull Request contains fixes of code or content (typos) labels Sep 17, 2024
@pg-ovh pg-ovh self-assigned this Sep 17, 2024
@pg-ovh pg-ovh added the Do not merge yet This Pull Request is awaiting a GO from product teams label Sep 23, 2024
@pg-ovh pg-ovh marked this pull request as ready for review September 23, 2024 16:10
@pg-ovh pg-ovh marked this pull request as draft September 24, 2024 12:45
@pg-ovh pg-ovh marked this pull request as ready for review September 24, 2024 13:31
@pg-ovh
Copy link
Contributor Author

pg-ovh commented Sep 24, 2024

Hello @OVH-Team-Guides, I have remove the changes from vcd get concepts guide from this PR for your information.

@Y0Coss
Copy link
Collaborator

Y0Coss commented Sep 24, 2024

Hello @OVH-Team-Guides, I have remove the changes from vcd get concepts guide from this PR for your information.

@pg-ovh , what you did is a deletion of the file. That may not be what you intended to do.

@pg-ovh
Copy link
Contributor Author

pg-ovh commented Sep 24, 2024

Hello @OVH-Team-Guides, I have remove the changes from vcd get concepts guide from this PR for your information.

@pg-ovh , what you did is a deletion of the file. That may not be what you intended to do.

Yes I just want to remove the folder from the PR and all changes made to the guide (VCD concepts), not remove the guide from the website.

@Y0Coss
Copy link
Collaborator

Y0Coss commented Sep 24, 2024

Hello @OVH-Team-Guides, I have remove the changes from vcd get concepts guide from this PR for your information.

@pg-ovh , what you did is a deletion of the file. That may not be what you intended to do.

Yes I just want to remove the folder from the PR and all changes made to the guide (VCD concepts), not remove the guide from the website.

Then you need to add the fr-fr file again in its folder. The guide version must be the one from the develop branch.

@pg-ovh pg-ovh marked this pull request as draft September 24, 2024 15:24
@pg-ovh pg-ovh marked this pull request as ready for review September 24, 2024 15:26
@pg-ovh pg-ovh removed the Do not merge yet This Pull Request is awaiting a GO from product teams label Sep 25, 2024
@Y0Coss Y0Coss merged commit 8452e85 into develop Sep 25, 2024
@Y0Coss Y0Coss deleted the pga_vcd_migrationv5 branch September 25, 2024 13:29
@Y0Coss
Copy link
Collaborator

Y0Coss commented Sep 25, 2024

Thank you for your contribution @pg-ovh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franckcosta franckcosta Awaiting requested review from franckcosta

Assignees

@pg-ovh pg-ovh

Labels
FIX The Pull Request contains fixes of code or content (typos) Update request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pg-ovh @Y0Coss