Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EGO public key fetching at boot #15

Open
rtisma opened this issue Oct 14, 2020 · 1 comment
Open

Add EGO public key fetching at boot #15

rtisma opened this issue Oct 14, 2020 · 1 comment
Assignees
Labels
canarie enhancement New feature or request SP:2

Comments

@rtisma
Copy link
Contributor

rtisma commented Oct 14, 2020

Currently, the EGO public key is configured via env variable. This means, the person deploying dms-ui needs to:

  • call the ego public key endpoint
  • extract the public key from the response
  • update the dms-ui qa and staging helm values
  • make a PR
  • get someone to review the PR
  • merge pr
  • redeploy the new public key

It would be better if instead dms-ui required EGOs public key url, and then on boot, it fetches the public key and uses that. If the public key changes, instead of going through the complicated steps above, the dms-ui just needs to do a rolling restarts (i.e k rollout restart deploy/dms-ui). This significantly simplifies the deployment process

@rtisma rtisma added this to the [FUTURE] Canarie Sprint 8 milestone Oct 14, 2020
@rtisma rtisma added the enhancement New feature or request label Oct 14, 2020
@b-f-chan
Copy link

After discussing with @anncatton and cnosultation with @hlminh2000 , it seems the EGO public key is actually currently NOT used at all in the DMS-UI code. The config is in the helm chart but is not required for any functionality. In the future, if we implement access control, this may be required, but for now it leads to confusion during deployment. Suggestion is to remove it from the DMS-UI code and the Helm chart config.

At minimum, we'll backlog it and discuss with @rtisma, but this will not be included in the next sprint.

@b-f-chan b-f-chan removed this from the Canarie Sprint 8 milestone Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
canarie enhancement New feature or request SP:2
Projects
None yet
Development

No branches or pull requests

3 participants