-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ "Update Existing Avatar" now properly updates the fst file #576
✨ "Update Existing Avatar" now properly updates the fst file #576
Conversation
It will now keep any previous edits instead of creating a brand-new file
adef9cb
to
d7fdc00
Compare
c55cf82
to
f747c3b
Compare
This PR should be ready for review now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny nitpick.
I've not written any C# for ages and looking at this I've obviously gotten rusty, but at least I don't see anything obviously objectionable. A second opinion would be nice though.
Also I don't know enough about avatars to properly evaluate what it's doing here, but that should be shown in testing.
} | ||
|
||
/*[MenuItem("Overte/Test")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be removed
The exporter will now keep any previous edits instead of creating a brand-new fst file
Todo