✨ "Update Existing Avatar" now properly updates the fst file #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksuprynowicz
added
enhancement
It will now keep any previous edits instead of creating a brand-new file
AnotherFoxGuy
force-pushed
the
unity-exporter-improvements
branch
from
adef9cb
to
d7fdc00
Compare
AnotherFoxGuy
force-pushed
the
unity-exporter-improvements
branch
from
c55cf82
to
f747c3b
Compare
|
This PR should be ready for review now |
daleglass
requested changes
Sep 4, 2023
There was a problem hiding this comment.
Just a tiny nitpick.
I've not written any C# for ages and looking at this I've obviously gotten rusty, but at least I don't see anything obviously objectionable. A second opinion would be nice though.
Also I don't know enough about avatars to properly evaluate what it's doing here, but that should be shown in testing.
| } | ||
|
|
||
| /*[MenuItem("Overte/Test")] |
daleglass
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exporter will now keep any previous edits instead of creating a brand-new fst file
Todo