Appreciate app removal #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removal of Appreciate from Interface scripts It will be in More App where it should have been.
|
Merging this, as the Appreciate app in its current state indeed seems to infringe upon the GPLv3 license. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR remove the "Appreciate" app from Interface.
The app has been added to the "more" app (PR 31 of the Community-App reposititory)
It has been removed from the DefaultScript
so it won't be present by default anymore.
(It was not an application used enough to worth to be systematically in the toolbar 100% of the time)
Doing transfer I also found that it was using a GPLv3 component
Keeping this in a Apache 2.0 project would have required that we change the licence to GPLv3 too. (which we don't want to)