Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix web entities not accepting keyboard focus #1187

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

HifiExperiments
Copy link
Member

@HifiExperiments HifiExperiments commented Oct 24, 2024

closes #1184

what happened here was:

  • EntityItem had a (virtual) method called wantsKeyboardFocus which always returned false
  • WebEntityItem had a method called wantsKeyboardFocus that was used as the getter for the property
  • RenderableEntityItem also has a (virtual) method called wantsKeyboardFocus which always returned false, which is overridden by RenderableWebEntityItem to return the value it copies from WebEntityItem
  • RenderableWebEntityItem performs the copy by calling _wantsKeyboardFocus = entity->wantsKeyboardFocus();
  • BUT in Automated entity property serialization #1098, the WebEntityItem getter was sneakily renamed to getWantsKeyboardFocus, so the copy was accidentally always copying false from EntityItem

@HifiExperiments HifiExperiments added bug Something isn't working needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested fix before release regression Something formerly worked and doesn't anymore labels Oct 24, 2024
Copy link
Member

@ksuprynowicz ksuprynowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ksuprynowicz ksuprynowicz merged commit 18c5fb1 into overte-org:master Oct 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix before release needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested regression Something formerly worked and doesn't anymore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tablet text entry doesn't work anymore
2 participants