Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially duplicate FileDiolog.qml #848

Open
Armored-Dragon opened this issue Mar 2, 2024 · 1 comment
Open

Potentially duplicate FileDiolog.qml #848

Armored-Dragon opened this issue Mar 2, 2024 · 1 comment

Comments

@Armored-Dragon
Copy link
Member

This issue is opened at the request of some users in the hub for discussion.
There are some files which look to be largely, but not entirely, duplicate qml files.

I've been doing testing on trying to see if I could replace the internal file picker and use the system's file picker. It seems like these files are used somewhere.

Maybe these could be condensed?

https://github.com/overte-org/overte/blob/9b89b3ffd9fe8bd9bd417f5a950b094aa807e577/interface/resources/qml/dialogs/FileDialog.qml

https://github.com/overte-org/overte/blob/9b89b3ffd9fe8bd9bd417f5a950b094aa807e577/interface/resources/qml/dialogs/TabletFileDialog.qml

https://github.com/overte-org/overte/blob/9b89b3ffd9fe8bd9bd417f5a950b094aa807e577/interface/resources/qml/hifi/tablet/tabletWindows/TabletFileDialog.qml

@Armored-Dragon
Copy link
Member Author

This will likely be addressed with PR #886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant