Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error at using some enums as runtime values #96

Open
Enderlook opened this issue Oct 19, 2023 · 0 comments
Open

Error at using some enums as runtime values #96

Enderlook opened this issue Oct 19, 2023 · 0 comments

Comments

@Enderlook
Copy link

The file types.d.ts uses export type to export some enums.
This prevents consumers from using those enums as values at runtime.
Shouldn't they be exported with export instead?

I found this happens with SortDirection and TokenSortKey due to this line:

zdk/src/types.ts

Lines 1 to 15 in e70abf9

export type {
AggregateAttributesQueryVariables,
CollectionSortKey,
CollectionSortKeySortInput,
CollectionsQuery,
CollectionsQueryInput,
SortDirection,
TokenInput,
TokenSortKey,
TokensQuery,
SalesVolumeQueryVariables,
OwnersByCountQueryVariables,
TokensQueryFilter,
TokensQueryInput,
} from './queries/queries-sdk';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant