Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSTree seems to be causing issues with flatpak update? #3319

Open
AtiusAmy opened this issue Oct 4, 2024 · 8 comments
Open

OSTree seems to be causing issues with flatpak update? #3319

AtiusAmy opened this issue Oct 4, 2024 · 8 comments

Comments

@AtiusAmy
Copy link

AtiusAmy commented Oct 4, 2024

I got this error when running Flatpak update (Alpine Edge):

OSTree:ERROR:src/libostree/ostree-repo-commit.c:3191:_ostree_repo_commit_modifier_apply: code should not be reached
Bail out! OSTree:ERROR:src/libostree/ostree-repo-commit.c:3191:_ostree_repo_commit_modifier_apply: code should not be reached

It originally looked like #3299, but on closer inspection it's different. I'm not sure if this is a problem with packaging or what, but I'm on Ostree 2024.8 (Flatpak 1.14.10)

@adamthiede
Copy link

Could you provide more details? (user or system remotes for example) I'm not able to reproduce this on Alpine Edge.

cgwalters added a commit to cgwalters/ostree that referenced this issue Oct 10, 2024
xref ostreedev#3319

It'd be useful to know what file type is being hit here; I believe
this code path should be unreachable.
@dbnicholson
Copy link
Member

@AtiusAmy could you try again with ostree main? Or, if you can apply the f11e6a4 as a patch to your distro's ostree, that would be also work. The commit code is intending to get either a regular file, directory or symlink at that spot. I don't know why flatpak would be trying to commit an object that isn't one of those types. The other types are documented here.

@AtiusAmy
Copy link
Author

It seems like this is an issue with the Fedora flatpak remote. Flathub updates have no issue with this?

I uh have no idea how patch it though

@dbnicholson
Copy link
Member

That seems plausible as Flathub builds with flatpak-builder, and I don't think anything has changed there that would suddenly start committing non-files. Fedora's flatpaks are built by a separate process that converts RPMs. That seems more likely that some non-file object would slip through the process.

For Fedora, @cgwalters can suggest the best way to patch ostree.

@cgwalters
Copy link
Member

Is there a specific app that's failing to update?

@AtiusAmy
Copy link
Author

Is there a specific app that's failing to update?

Fedora KDE5 platform, specifically for Krita.

I also removed and tried to reinstall but it didn't work. Also tried installing GChemPaint and it didn't work either

@cgwalters
Copy link
Member

Please be as specific as possible. Is this runtime/org.fedoraproject.KDE5Platform/x86_64/f41 and/or app/org.kde.krita/x86_64/stable ?

@AtiusAmy
Copy link
Author

Please be as specific as possible. Is this runtime/org.fedoraproject.KDE5Platform/x86_64/f41 and/or app/org.kde.krita/x86_64/stable ?

I believe it was runtime/org.fedoraproject.KDE5Platform/x86_64/f40 which at the time Krita depended on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants