Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n module #409

Open
mouafus opened this issue May 29, 2023 · 8 comments
Open

I18n module #409

mouafus opened this issue May 29, 2023 · 8 comments
Assignees

Comments

@mouafus
Copy link

mouafus commented May 29, 2023

I would like to add multi-lang on this app, is anyone working on it yet ?

@elhmn @Sanix-Darker @FanJups

@Sanix-Darker
Copy link
Member

Hello @mouafus , am not sure it's already planed, so yeah, you can go ahead with it !
Can you just add more indications on how you're going to implement it please ? 🙏🏽

@mouafus
Copy link
Author

mouafus commented May 30, 2023

Hello @Sanix-Darker
I will add the i18n module to facilitate translation through translation files, and add an element to the user interface for interface change.

@elhmn
Copy link
Member

elhmn commented May 31, 2023

Hello @Sanix-Darker I will add the i18n module to facilitate translation through translation files, and add an element to the user interface for interface change.

I don't think anyone is working on it currently, we are building new feature and I think picking up i18n will cause some friction.
But feel free to pick that up, we will find ways sync that with the new feature.

@mouafus
Copy link
Author

mouafus commented May 31, 2023

Hello @Sanix-Darker I will add the i18n module to facilitate translation through translation files, and add an element to the user interface for interface change.

I don't think anyone is working on it currently, we are building new feature and I think picking up i18n will cause some friction. But feel free to pick that up, we will find ways sync that with the new feature.

Okay, I've almost finished this module locally, I'd like to be notified when it's possible to merge please !

@elhmn
Copy link
Member

elhmn commented May 31, 2023

You need to create a pull request before it can get merged

@mouafus mouafus mentioned this issue May 31, 2023
@mouafus
Copy link
Author

mouafus commented May 31, 2023

You need to create a pull request before it can get merged

done !

@elhmn
Copy link
Member

elhmn commented Jun 2, 2023

You need to create a pull request before it can get merged

done !

Could you share a link please ?

@mouafus
Copy link
Author

mouafus commented Jun 2, 2023

You need to create a pull request before it can get merged

done !

Could you share a link please ?

#414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

4 participants