Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes docs #98

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Nodes docs #98

wants to merge 4 commits into from

Conversation

thedevmanek
Copy link
Contributor

Adds Documentation for Minimum Nodes

@marcoag
Copy link
Member

marcoag commented Sep 23, 2022

I wouldn't say this subsection fits into the ROS 2 section as that one is specific for ROS 2 only documentation and what we are trying to add is on the RMF side of things. In fact there is already a section that talks about RMF simulation launch files that might be worth taking a look at and maybe merging some of the stuff here: https://github.com/thedevmanek/ros2multirobotbook/blob/nodes-docs/src/simulation.md#launch-files

We could add this info in the Simulation section. Maybe merge some of the launch stuff and then add a subsection for the explanation of the nodes? I would also like some more explanation on the nodes side like where's the code (links), how do they operate, who do they communicate with, configuration, messages... maybe it would be good to add some graph showing the nodes interaction (maybe generate one with rviz?) and how do they communicate, also the web side of things that communicates through websockets, how does it does that? are there any db involved?

@marcoag
Copy link
Member

marcoag commented Oct 14, 2022

It seems like the images have a circle in the bottom-left, is it relevant? if so can we add an explanation? if not, can the images be edited and remove this?

@thedevmanek
Copy link
Contributor Author

thedevmanek commented Oct 14, 2022

It seems like the images have a circle in the bottom-left, is it relevant? if so can we add an explanation? if not, can the images be edited and remove this?

It was just there, there is no meaning to it. I have removed it in 89fd78f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants