Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - POI Context menu (Photos Gallery / Rows) #17949

Closed
6 tasks done
vshcherb opened this issue Aug 17, 2023 · 4 comments
Closed
6 tasks done

Web - POI Context menu (Photos Gallery / Rows) #17949

vshcherb opened this issue Aug 17, 2023 · 4 comments
Assignees
Milestone

Comments

@vshcherb
Copy link
Member

vshcherb commented Aug 17, 2023

ToDo part 1

  • Initially we need to implement as Android
  • Think about displaying Photo on top or redesign top bar for POI Context menu

Implement for testing all new features with backend

BUGS missing photos P180/P373/P18

Part

Images in context menu

  • Tap on photo should open the same photo in Open photo mode
  • Tap Show all, should open Gallery mode

Gallery, Figma

Gallery Open photo
  • Tap back should open context menu
  • Tap on photo, switch Gallery to the photo

To do (backend)

@vshcherb vshcherb added this to the 4.6-backend milestone Aug 17, 2023
@vshcherb vshcherb changed the title Display photos of POI similar to Android Web - Display photos of POI similar to Android Aug 17, 2023
@vshcherb vshcherb modified the milestones: 4.6-backend, 4.7-backend Dec 13, 2023
@alisa911
Copy link
Contributor

protected List<ImageCard> doInBackground(Void... voids) {

@vshcherb vshcherb modified the milestones: 4.7-backend, web Feb 1, 2024
@vshcherb vshcherb modified the milestones: 4.7-web, 4.8-web Mar 11, 2024
@vshcherb vshcherb changed the title Web - Display photos of POI similar to Android Web - POI Display photos of similar to Android May 8, 2024
@vshcherb vshcherb changed the title Web - POI Display photos of similar to Android Web - POI / Photos Gallery May 8, 2024
@vshcherb vshcherb changed the title Web - POI / Photos Gallery Web - POI Context menu (Photos Gallery) May 9, 2024
@vshcherb vshcherb changed the title Web - POI Context menu (Photos Gallery) Web - POI Context menu (Photos Gallery / Rows) May 16, 2024
@dmpr0
Copy link
Contributor

dmpr0 commented Jun 18, 2024

Review

Screenshot
  • Show selection on selected photo
  • Scroll photo list, to show actual position. if possible.
  • Image should fill width or height of the frame (less black borders)
  • Can we add support to view gallery by clicking on keyboard arrow buttons?

  • Tap on photo in context menu should open the same photo in Gallery

Screenshot
  • AppBar should be visible while scrolling

Screenshot
  • Taping on POI should open context menu. Currently if gallery opens, it doesn't work.

  • Try to use images with lower resolution. For example New York

Screenshot
  • Blank white screen is show after each switching to OsmAnd Maps tab with opened Gallery.

@dmpr0
Copy link
Contributor

dmpr0 commented Jun 21, 2024

Review

Screenshot
Context menu details Photos page
  • Show click state cursor when hovering on photo

Screenshot
  • Metada

Screenshot

@alisa911
Copy link
Contributor

alisa911 commented Jul 5, 2024

Adding descriptions to photos will involve mandatory parsing of data by link for each picture (query to wikimedia). There are 46 million pictures in total, and now almost 9 use pre-parsed data from latest-mediainfo.json.bz2. This speeds up work with the gallery a little.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants