Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inscription tags are erroneously treated as links #17466

Closed
bdwz-osm opened this issue Jun 20, 2023 · 2 comments · Fixed by #17659
Closed

Inscription tags are erroneously treated as links #17466

bdwz-osm opened this issue Jun 20, 2023 · 2 comments · Fixed by #17659
Assignees
Labels
Milestone

Comments

@bdwz-osm
Copy link

bdwz-osm commented Jun 20, 2023

Description

Adding a properly-formatted inscription=* tag with spaced line breaks (/) and paragraph breaks (//) causes OSMAnd to highlight the entire text and recognize it as a URL, even without any other elements of a web link present.

Note that the text of an inscription might actually contain a link, so completely disabling links for the value of inscription isn't a good solution.

Steps to reproduce

  • Tap on a map feature with an inscription tag, such as a memorial, that contains line or paragraph breaks
  • Observe the orange-highlighted text beneath ":information_source: Inscription"
  • Tap it to open in browser and find that it's not a URL at all

Actual result

Inscription text can be opened in browser as a non-functional URL

Expected result

Non-URL text to remain unavailable for interaction

Your Environment

OsmAnd Version: 4.3.12
Android/iOS version: Android v13
Device model: lol

@bdwz-osm bdwz-osm changed the title Inscription tags are treated as links Inscription tags are erroneously treated as links Jun 20, 2023
@DmitryAlexei
Copy link
Contributor

Reproduced OsmAnd~ 4.5.0#382m, released: 2023-07-12

48.7823370, 9.1824859
https://www.openstreetmap.org/node/5504782341

  • inscription=* tag with spaced line (/) is recognized by OsmAnd as weblink
  • clicking on such text opens a blank page in the browser

@bdwz-osm Next time, please provide a link to the object and screenshots, this will speed up reproducing

@vshcherb vshcherb added this to the 4.5-android milestone Jul 13, 2023
@vshcherb
Copy link
Member

vshcherb commented Jul 13, 2023

inscription and other tags needs to be checked if they start with http:// or https://

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants