Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinity loop in those bus routes whats contain a bus stops at twice #15449

Closed
2 tasks
summoner001 opened this issue Oct 9, 2022 · 8 comments · Fixed by #17529
Closed
2 tasks

Infinity loop in those bus routes whats contain a bus stops at twice #15449

summoner001 opened this issue Oct 9, 2022 · 8 comments · Fixed by #17529
Assignees
Milestone

Comments

@summoner001
Copy link

summoner001 commented Oct 9, 2022

🐞 routing report

Routing engine

  • [ x] OsmAnd's in-app offline routing
  • Any online routing provider (YOURS, openrouteservice, OSRM, etc.)

Routing Profile

Browsing

Start and end points

The bus route: https://www.openstreetmap.org/relation/14616287#map=14/47.2179/21.5378

If I open the bus route in OsmAND and stepping the stations with the next button, OsmAND get into an infinite loop if a bus route includes a bus stop at twice, even though the timetable actually says it stops at that bus stop at twice in a single outward journey.

1st bus stop => 2nd bus stop => 3rd bus stop => ... => 9th bus stop (Berettyóújfalu, bus station) (first) => 10th bus stop (hospital) => 11th bus stop (Berettyóújfalu, bus station) (second, again) and at this point osmand don't jump to 12th bus stop when i click the next button. Osmand get into trouble and infinite loop 10th bus stop <=> 11th bus stop he never jump to 12th bus stop.

The bus stops are not incorrectly included twice in the route. This is the correct timetable.

Screen-20221009-114603-360x480.mp4

Actual and expected routes

Is this a regression?

No

🌍 Your Environment

OsmAnd Version: v4.2.7 (F-Droid)





Device and Android/iOS version:
Android 9
Maps used (online or offline):

  • [ x] Offline maps offered within the OsmAnd app for download.
  • Online (tile / raster) maps

Anything else relevant?

@Max1234-Ita
Copy link
Contributor

Hi, could it be similar to this?
#15013

I just stumbled on it while searching for a different issue and I thought these can be related, feel free to correct me, if I'm wrong.

@summoner001
Copy link
Author

I think the two problems are not the same.
#15013 Navigation has a problem with route search. Or it can be caused by a wrong mandatory direction of travel at an intersection. I have encountered such an error and corrected it in osm.

But in this issue, however, the bus route viewer cannot identify the bus stop if it appears twice in the route. The viewer thinks it is there for the first time. But it is the second time.

@ivanPyrohivskyi
Copy link
Contributor

@summoner001
Copy link
Author

Stop Berettyóújfalu, autóbusz-állomás is present in Berettyószentmárton => Berettyóújfalu TESCO twice.

Yes the bus stop present in the route at twice. But this is the bus's timetable. The bus stopping at twice in the route. This is not problem!

@ivanPyrohivskyi
Copy link
Contributor

Need to fix in iOS also

@nnngrach
Copy link
Contributor

@alex-osm
Copy link
Contributor

@DmitryAlexei
Copy link
Contributor

OsmAnd~ 4.6.0#489m, released: 2023-07-26

video_2023-07-27_18-30-14.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants