-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[assertj,cm] Assertions and Conditions on CofigurationEvent #791
base: main
Are you sure you want to change the base?
Conversation
Could you give me your general thoughts on that. |
...assertj.cm/src/main/java/org/osgi/test/assertj/cm/configuration/ConfigurationConditions.java
Show resolved
Hide resolved
.../src/main/java/org/osgi/test/assertj/cm/configurationevent/ConfigurationEventConditions.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks promising, but I think it needs tidying up a little. There are a few things which are currently public
which I think should probably not be considered API (and therefore need to be default visibility).
7b89f18
to
f332337
Compare
Signed-off-by: Stefan Bischof <[email protected]>
@timothyjward I am Ready with this PR Here are some examples of how the conditions we publish could describe a Assert-Result:
|
No description provided.