From ad7306f91bb338aed4b95200e510bc68d8f410e3 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Wed, 23 Oct 2024 08:51:34 +0200 Subject: [PATCH] Add parent checks to PBW algebra arithmetics --- src/Rings/PBWAlgebra.jl | 6 +++++- src/Rings/PBWAlgebraQuo.jl | 7 ++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/Rings/PBWAlgebra.jl b/src/Rings/PBWAlgebra.jl index 515989d88413..95456c792c24 100644 --- a/src/Rings/PBWAlgebra.jl +++ b/src/Rings/PBWAlgebra.jl @@ -266,14 +266,17 @@ function one(R::PBWAlgRing) end function Base.:(==)(a::PBWAlgElem, b::PBWAlgElem) + check_parent(a, b) return a.sdata == b.sdata end function Base.:+(a::PBWAlgElem, b::PBWAlgElem) + check_parent(a, b) return PBWAlgElem(parent(a), a.sdata + b.sdata) end function Base.:-(a::PBWAlgElem, b::PBWAlgElem) + check_parent(a, b) return PBWAlgElem(parent(a), a.sdata - b.sdata) end @@ -282,7 +285,8 @@ function Base.:-(a::PBWAlgElem) end function Base.:*(a::PBWAlgElem, b::PBWAlgElem) - return PBWAlgElem(parent(a), a.sdata*b.sdata) + check_parent(a, b) + return PBWAlgElem(parent(a), a.sdata * b.sdata) end function Base.:^(a::PBWAlgElem, b::Int) diff --git a/src/Rings/PBWAlgebraQuo.jl b/src/Rings/PBWAlgebraQuo.jl index a717e729c19d..60082c3a8369 100644 --- a/src/Rings/PBWAlgebraQuo.jl +++ b/src/Rings/PBWAlgebraQuo.jl @@ -169,12 +169,12 @@ function Base.:(==)(a::PBWAlgQuoElem, b::PBWAlgQuoElem) end function Base.:+(a::PBWAlgQuoElem, b::PBWAlgQuoElem) - @assert parent(a) == parent(b) + check_parent(a, b) return PBWAlgQuoElem(parent(a), a.data + b.data) end function Base.:-(a::PBWAlgQuoElem, b::PBWAlgQuoElem) - @assert parent(a) == parent(b) + check_parent(a, b) return PBWAlgQuoElem(parent(a), a.data - b.data) end @@ -183,7 +183,8 @@ function Base.:-(a::PBWAlgQuoElem) end function Base.:*(a::PBWAlgQuoElem, b::PBWAlgQuoElem) - return PBWAlgQuoElem(parent(a), a.data*b.data) + check_parent(a, b) + return PBWAlgQuoElem(parent(a), a.data * b.data) end function Base.:^(a::PBWAlgQuoElem, b::Int)