t: Improve mocked commands #5948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5948 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 396 396
Lines 38966 38966
=======================================
Hits 38482 38482
Misses 484 484 ☔ View full report in Codecov by Sentry. |
Martchus
approved these changes
Sep 25, 2024
okurz
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Good. No need to force merge. I would prefer to have https://progress.opensuse.org/issues/167272 fixed first
To be able to have valid git commands in our test (e.g. for copy/paste) we now at least quote any argument that has a space in it. Related issue: https://progress.opensuse.org/issues/164898
perlpunk
force-pushed
the
git-ssh-mock
branch
from
fcf9627
to
8ab262e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to have valid git commands in our test (e.g. for copy/paste) we now at least quote any argument that has a space in it.
Related issue: https://progress.opensuse.org/issues/164898