From d943a4177670946bf43e9491edcc01f218bdbf89 Mon Sep 17 00:00:00 2001
From: Oliver Kurz <okurz@suse.de>
Date: Wed, 21 Feb 2024 08:40:51 +0100
Subject: [PATCH] Simplify CLI::monitor with 'all' function

---
 lib/OpenQA/CLI/monitor.pm | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/OpenQA/CLI/monitor.pm b/lib/OpenQA/CLI/monitor.pm
index 4d36b406491..320ff69517d 100644
--- a/lib/OpenQA/CLI/monitor.pm
+++ b/lib/OpenQA/CLI/monitor.pm
@@ -5,6 +5,7 @@ package OpenQA::CLI::monitor;
 use Mojo::Base 'OpenQA::Command', -signatures;
 
 use OpenQA::Jobs::Constants;
+use List::Util qw(all);
 use Mojo::Util qw(encode getopt);
 
 has description => 'Monitors a set of jobs';
@@ -28,10 +29,7 @@ sub _monitor_jobs ($self, $client, $poll_interval, $job_ids, $job_results) {
 }
 
 sub _compute_return_code ($self, $job_results) {
-    for my $job_result (@$job_results) {
-        return 2 unless OpenQA::Jobs::Constants::is_ok_result($job_result);
-    }
-    return 0;
+    (all { OpenQA::Jobs::Constants::is_ok_result($_) } @$job_results) ? 0 : 2;
 }
 
 sub _monitor_and_return ($self, $client, $poll_interval, $job_ids) {