Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support disabling easter eggs #45

Closed
orhun opened this issue Oct 15, 2023 · 0 comments · Fixed by #48
Closed

Support disabling easter eggs #45

orhun opened this issue Oct 15, 2023 · 0 comments · Fixed by #48
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@orhun
Copy link
Owner

orhun commented Oct 15, 2023

Is your feature request related to a problem? Please describe.

I personally like them, but maybe add a flag/config option to disable them for those who don't.

Originally posted by @Xenira in #14 (comment)

Describe the solution you'd like

Add --no-surprises Disables easter eggs argument or something similar. It should also be configurable from the configuration file.

I'm open for naming suggestions.

Describe alternatives you've considered

Also support environment variables.

Additional context

You need to find where the easter eggs are to disable them, just a hint, search for "ak47" in the repo.

See #14
@orhun orhun added enhancement New feature or request good first issue Good for newcomers labels Oct 15, 2023
@orhun orhun mentioned this issue Oct 15, 2023
Open
@Xenira Xenira mentioned this issue Oct 15, 2023
Merged
@orhun orhun closed this as completed in #48 Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(config): add option to disable easter eggs Xenira/daktilo
1 participant
@orhun