Cleanup

[larsnaesbye]

A simple code analysis run shows a lot of potential improvements across the entire project.
Some things can be fixed quite easily, like unused imports can just be removed.

Others can't be automatically fixed by the IDE, because it'll make guesses as to variable names that might make the code less readable.

[mokun]

A simple code analysis run shows a lot of potential improvements across the entire project.
Some things can be fixed quite easily, like unused imports can just be removed.

Sure. May be you can let us know here in this thread starting with whatever the most critical to fix.

[larsnaesbye]

Yeah. The pull requests I made and which you merged were from this list :-)

[bevans2000]

@larsnaesbye I totally agree that the project has a lot of code waiting to fail. I've been tackling some as I've been making changes but there are still a lot. In particular there is a lot of duplicate code. I would like to add a GitFlow to regularly update the static code output in SonarCloud.

https://sonarcloud.io/dashboard?id=com.github.mars-sim%3Amars-sim

[bevans2000]

Agreed, we should use the Maven artifact and drop the code. Let's make an Issue for this problem.

I think I have found a way to do the Sonarcloud now on push to master. I'll try and sort it over the weekend if I can find time.

[larsnaesbye]

Hmm... the artifact seems old: https://mvnrepository.com/artifact/eu.hansolo/SteelSeries
August 2012 is a very long time ago. Is the main developer still working on it?

[larsnaesbye]

He's moved to JavaFX instead I think - https://mvnrepository.com/artifact/eu.hansolo/Medusa

[bevans2000]

SonarCloud analysis is called when there is a push to the master branch. It doesn't trigger on forked repos.
I have added a badge to the Readme as well.

[mokun]

He's moved to JavaFX instead I think - https://mvnrepository.com/artifact/eu.hansolo/Medusa

@larsnaesbye

When we were trying to rebuild mars-sim UI using JavaFX back then, we did try using Medusa. It really have a lot of nice widgets we can use. I recall we even used some for presenting the Personality Traits for settlers.

[bevans2000]

For months I've been focussing on refactoring and improving the design and performance but I'm going to change tack for a while and look at the Critical & Major bugs/CodeSmells reported by SonarCloud.

[larsnaesbye]

Good idea. Let's get some better ratings and try to get the bugs, smells and vulnerabilities count down.