ServiceAccount annotation is only added to logging-operator serviceaccount

[WTPascoe]

Bugs should be filed for issues encountered whilst operating logging-operator.
You should first attempt to resolve your issues through the community support
channels, e.g. Slack, in order to rule out individual configuration errors. #logging-operator
Please provide as much detail as possible.

Describe the bug:
When deploying the logging operator with a service account annotation to use an EKS role (IRSA), the annotation is only created on the logging-operator service account during helm install and not on subsequent accounts created when creating logging resources.

I think this may be a documentation issue, and that I simply need to include config in the following section of the logging resource, but I couldn't find documentation on whether that is the case or not.

spec:
  fluentd: {}
  fluentbit: {}

Expected behaviour:
all of the following service accounts should have the IRSA annotation applied:

• logging-fluentbit
• logging-fluentd
• logging-operator

Steps to reproduce the bug:
helm upgrade --install --version 3.17.9 --wait --values values.yml --namespace logging logging-operator banzaicloud-stable/logging-operator

values.yml contents

createCustomResource: false
serviceAccount:
  annotations: 
    eks.amazonaws.com/role-arn: "arn:aws:iam::myacc:role/myrole"

Check annotation

$ k get sa logging-operator -o yaml| grep -A3 annotation
  annotations:
    eks.amazonaws.com/role-arn: arn:aws:iam::myacc:role/myrole
    meta.helm.sh/release-name: logging-operator
    meta.helm.sh/release-namespace: logging

Create logging resource

$ kubectl -n logging apply -f - <<EOF
apiVersion: logging.banzaicloud.io/v1beta1
kind: Logging
metadata:
  name: logging
spec:
  fluentd: {}
  fluentbit: {}
  controlNamespace: logging
EOF

Newly created service account does not have annotation

$ k get sa logging-fluentd -o yaml | gre
p -A3 annotation
  annotations:
    banzaicloud.com/last-applied: <removed>
  creationTimestamp: "2022-10-18T11:03:01Z"
  labels:

Additional context:
Add any other context about the problem here.

Environment details:

• Kubernetes version (e.g. v1.15.2): 1.23
• Cloud-provider/provisioner (e.g. AKS, GKE, EKS, PKE etc): AWS EKS
• logging-operator version (e.g. 2.1.1): 3.17.9
• Install method (e.g. helm or static manifests): helm

/kind bug

[yurrriq]

I couldn't find solid documentation either, but you can do the following in a Logging resource:

spec:
  fluentd:
    serviceAccount:
      metadata:
        annotations:
          eks.amazonaws.com/role-arn: "arn:aws:iam::myacc:role/myrole"

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!