From 468fcb93d88c11039feb330e358c73e239a33d6e Mon Sep 17 00:00:00 2001 From: Mior Muhammad Zaki Date: Fri, 21 Jul 2023 21:53:12 +0800 Subject: [PATCH] wip Signed-off-by: Mior Muhammad Zaki --- composer.json | 8 ++++++++ src/UpdateCommand.php | 2 +- src/helpers.php | 10 ++++++++++ 3 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 src/helpers.php diff --git a/composer.json b/composer.json index 5d1cd74..2b78f8d 100644 --- a/composer.json +++ b/composer.json @@ -19,6 +19,14 @@ "autoload": { "psr-4": { "Orchestra\\DuskUpdater\\": "src/" + }, + "files": [ + "src/helpers.php" + ] + }, + "autoload-dev": { + "psr-4": { + "Orchestra\\DuskUpdater\\Tests\\": "tests/" } }, "require": { diff --git a/src/UpdateCommand.php b/src/UpdateCommand.php index 2f91a43..95816ab 100644 --- a/src/UpdateCommand.php +++ b/src/UpdateCommand.php @@ -134,7 +134,7 @@ protected function rename(string $binary, string $os): void throw new RuntimeException("Unable to rename {$binary} without --install-dir"); } - $newName = array_reverse(explode(DIRECTORY_SEPARATOR, str_replace('chromedriver', 'chromedriver-'.$os, $binary), 2))[0]; + $newName = chromedriver_binary_filename($binary, $os); rename($this->directory.$binary, $this->directory.$newName); diff --git a/src/helpers.php b/src/helpers.php new file mode 100644 index 0000000..8eb065f --- /dev/null +++ b/src/helpers.php @@ -0,0 +1,10 @@ + 0 + ? array_reverse(explode(DIRECTORY_SEPARATOR, str_replace('chromedriver', 'chromedriver-'.$os, $binary), 2))[0] + : str_replace('chromedriver', 'chromedriver-'.$os, $binary); +}