implement custom client_credentials grant & add support of pkce to device_grant #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement client_credentials grant type Signed-off-by: Houssem Ben Mabrouk <[email protected]> * include pkce_verifier + upgrade oauth2 Signed-off-by: Houssem Ben Mabrouk <[email protected]> * append issuer prefix to device redirectURI Signed-off-by: Houssem Ben Mabrouk <[email protected]> * fix lint? Signed-off-by: Houssem Ben Mabrouk <[email protected]> * fix test Signed-off-by: Houssem Ben Mabrouk <[email protected]> --------- Signed-off-by: Houssem Ben Mabrouk <[email protected]>
Signed-off-by: Houssem Ben Mabrouk <[email protected]>
This reverts commit 65c6d32.
Signed-off-by: Houssem Ben Mabrouk <[email protected]>
* feat: dynamic oauth2 credentials client_credential flow Signed-off-by: Houssem Ben Mabrouk <[email protected]> * adding tests for client_credentials flow Signed-off-by: Houssem Ben Mabrouk <[email protected]> * better credentials handling + adjust tests Signed-off-by: Houssem Ben Mabrouk <[email protected]> * fix lint Signed-off-by: Houssem Ben Mabrouk <[email protected]> --------- Signed-off-by: Houssem Ben Mabrouk <[email protected]>
|
LGTM |
FernandezBenjamin
approved these changes
Apr 22, 2024
orange-hbenmabrouk
merged commit 948d7f4
into
release-orange-v2.39.0
7 of 8 checks passed
orange-hbenmabrouk
added a commit
that referenced
this pull request
May 16, 2024
…vice_grant (#7) * Feature/integrate client credentials nd pcke verifie (#5) * implement client_credentials grant type Signed-off-by: Houssem Ben Mabrouk <[email protected]> * include pkce_verifier + upgrade oauth2 Signed-off-by: Houssem Ben Mabrouk <[email protected]> * append issuer prefix to device redirectURI Signed-off-by: Houssem Ben Mabrouk <[email protected]> * fix lint? Signed-off-by: Houssem Ben Mabrouk <[email protected]> * fix test Signed-off-by: Houssem Ben Mabrouk <[email protected]> --------- Signed-off-by: Houssem Ben Mabrouk <[email protected]> * test to be reverted Signed-off-by: Houssem Ben Mabrouk <[email protected]> * Revert "test to be reverted" This reverts commit 65c6d32. * add client_credentials to default oauth2 grant types Signed-off-by: Houssem Ben Mabrouk <[email protected]> * Modify client credential grant (#6) * feat: dynamic oauth2 credentials client_credential flow Signed-off-by: Houssem Ben Mabrouk <[email protected]> * adding tests for client_credentials flow Signed-off-by: Houssem Ben Mabrouk <[email protected]> * better credentials handling + adjust tests Signed-off-by: Houssem Ben Mabrouk <[email protected]> * fix lint Signed-off-by: Houssem Ben Mabrouk <[email protected]> --------- Signed-off-by: Houssem Ben Mabrouk <[email protected]> --------- Signed-off-by: Houssem Ben Mabrouk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.