From 212df8e0ee22c27b14fed9a151bd62d4e98cf170 Mon Sep 17 00:00:00 2001 From: Cedric-Magnan <43343135+Cedric-Magnan@users.noreply.github.com> Date: Wed, 18 May 2022 15:31:51 +0200 Subject: [PATCH 1/3] Update oauth2.go Signed-off-by: Cedric-Magnan --- server/oauth2.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/server/oauth2.go b/server/oauth2.go index bb0058a74a..3661934596 100644 --- a/server/oauth2.go +++ b/server/oauth2.go @@ -138,6 +138,10 @@ const ( responseTypeCode = "code" // "Regular" flow responseTypeToken = "token" // Implicit flow for frontend apps. responseTypeIDToken = "id_token" // ID Token in url fragment + responseTypeCodeToken = "code token" // "Regular" flow + Implicit flow + responseTypeCodeIDToken = "code id_token" // "Regular" flow + ID Token + responseTypeIDTokenToken = "id_token token" // ID Token + Implicit flow + responseTypeCodeIDTokenToken = "code id_token token" // "Regular" flow + ID Token + Implicit flow ) const ( From 791657276ec512845347610a171c2758460e0012 Mon Sep 17 00:00:00 2001 From: Cedric-Magnan <43343135+Cedric-Magnan@users.noreply.github.com> Date: Wed, 18 May 2022 15:38:36 +0200 Subject: [PATCH 2/3] Update server.go Signed-off-by: Cedric-Magnan --- server/server.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/server.go b/server/server.go index f23eb54b7c..6bb39ec384 100755 --- a/server/server.go +++ b/server/server.go @@ -218,9 +218,9 @@ func newServer(ctx context.Context, c Config, rotationStrategy rotationStrategy) for _, respType := range c.SupportedResponseTypes { switch respType { - case responseTypeCode, responseTypeIDToken: + case responseTypeCode, responseTypeIDToken, responseTypeCodeIDToken: // continue - case responseTypeToken: + case responseTypeToken, responseTypeCodeToken, responseTypeIDTokenToken, responseTypeCodeIDTokenToken: // response_type=token is an implicit flow, let's add it to the discovery info // https://datatracker.ietf.org/doc/html/rfc6749#section-4.2.1 supportedGrant = append(supportedGrant, grantTypeImplicit) From 7e4798a7a442a646de9d713a400f8228084793bc Mon Sep 17 00:00:00 2001 From: Cedric-Magnan Date: Wed, 1 Jun 2022 10:28:03 +0200 Subject: [PATCH 3/3] fix: linting with gofmt Signed-off-by: Cedric-Magnan --- server/oauth2.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/server/oauth2.go b/server/oauth2.go index 3661934596..94398c162c 100644 --- a/server/oauth2.go +++ b/server/oauth2.go @@ -135,12 +135,12 @@ const ( ) const ( - responseTypeCode = "code" // "Regular" flow - responseTypeToken = "token" // Implicit flow for frontend apps. - responseTypeIDToken = "id_token" // ID Token in url fragment - responseTypeCodeToken = "code token" // "Regular" flow + Implicit flow - responseTypeCodeIDToken = "code id_token" // "Regular" flow + ID Token - responseTypeIDTokenToken = "id_token token" // ID Token + Implicit flow + responseTypeCode = "code" // "Regular" flow + responseTypeToken = "token" // Implicit flow for frontend apps. + responseTypeIDToken = "id_token" // ID Token in url fragment + responseTypeCodeToken = "code token" // "Regular" flow + Implicit flow + responseTypeCodeIDToken = "code id_token" // "Regular" flow + ID Token + responseTypeIDTokenToken = "id_token token" // ID Token + Implicit flow responseTypeCodeIDTokenToken = "code id_token token" // "Regular" flow + ID Token + Implicit flow )