Improved aqua telemetry #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
|
📌 Cov diff with main: 📌 Overall coverage: |
lu-ohai
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
|
📌 Cov diff with main: 📌 Overall coverage: |
VipulMascarenhas
previously approved these changes
Nov 8, 2024
mrDzurb
previously approved these changes
Nov 8, 2024
| @@ -69,6 +69,12 @@ def inner_function( | |||
| reason=error.message, | |||
| service_payload=error.args[0] if error.args else None, | |||
| exc_info=sys.exc_info(), | |||
| aqua_api_details=dict( | |||
There was a problem hiding this comment.
NIT: I would rather suggest to use the get operator to extract attributes from error objects.
aqua_api_details = {
"aqua_api_name": func.__qualname__,
"oci_api_name": getattr(error, "operation_name", "Unknown Operation"),
"service_endpoint": getattr(error, "request_endpoint", "Unknown Endpoint")
}
544a223
|
📌 Cov diff with main: 📌 Overall coverage: |
VipulMascarenhas
approved these changes
Nov 12, 2024
mrDzurb
approved these changes
Nov 12, 2024
|
📌 Cov diff with main: No lines with coverage information in this diff. 📌 Overall coverage: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved aqua telemetry
-- aqua api name
-- oci api name
-- service endpoint
Results