Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Attempt to make optimas generators compatible with generator standard #249

Open
wants to merge 38 commits into
base: main
Choose a base branch
from

Conversation

RemiLehe
Copy link
Collaborator

Overall approach:

optimas generators currently call the ask and tell methods, which, under the hood, can the _ask and _tell methods.

In this PR:

  • ask/tell are renamed to ask_trials/tell_trials and keep the same interface (for compatibility with the rest of the framework)
  • _ask/_tell are renamed to ask/tell and adopt the new standardized interface.

This allows other packages to use the optimas generators. (In this case, these other packages will call the new, standardized ask/tell directly, without going through ask_trials/tell_trials.)

In order to wrap a standardized generator from another package, one would only need to make a thin wrapper around it that defines ask_trials and tell_trials.

RemiLehe and others added 30 commits July 10, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant