Use more robust calculation of the emittance. #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
force-pushed
the
fix_warpx_script
branch
from
aa651ed
to
7bcfccb
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
RemiLehe
changed the title
|
This works and fixes the problem :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the issue reported in #236, it turns out that, for some input parameters, the simulation returned on only 2 macroparticles at the end of the acceleration stage.
In this case, this case, the emittance should be exactly 0, but due to floating-point errors, the quantity
x2*u2 -xu**2happened to be negative.This PR checks that the number of particles is bigger than 2, to avoid this type of error