Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin.glob -> plugin.detectChangesGlob #100

Open
samuelstroschein opened this issue Oct 16, 2024 — with Linear · 1 comment
Open

plugin.glob -> plugin.detectChangesGlob #100

samuelstroschein opened this issue Oct 16, 2024 — with Linear · 1 comment

Comments

Copy link
Member

Context

The glob property of a plugin is only used for invoking plugin.detectChanges. It's likely better to make this explicit to ease comprehension and de-couple other plugin APIs from defining a glob.

Proposal

Rename plugin.glob to plugin.detectChangesGlob to:

  • de-couple plugins from only dealing with files (we will likely introduce more APIs in the future)
  • explicit "detect changes is invoked via the detectChangesGlob`
Copy link
Member Author

Just ran into this in opral/monorepo@f956969. We defined glob in all tests even though it was only needed for detectChanges.

aka, the proposal makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant