Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move production models to share/model/ and improve naming #386

Open
zaucker opened this issue Dec 29, 2020 · 2 comments
Open

Move production models to share/model/ and improve naming #386

zaucker opened this issue Dec 29, 2020 · 2 comments
Assignees
@zaucker
Labels
refactoring

Comments

@zaucker
Copy link
Contributor

zaucker commented Dec 29, 2020

  • Add as sub repo to code repo
@zaucker zaucker self-assigned this Dec 29, 2020
@zaucker
Copy link
Contributor Author

zaucker commented Feb 25, 2021

After various discussions I think it is better to keep the models inside the same repo, as they are not usable separately.
From a user perspective, the distinction of application code and model descriptions is irrelevant.

@zaucker
Copy link
Contributor Author

zaucker commented Feb 25, 2021

TODO:

  • better model name(s)
  • better variant switch names
  • move production model to `share/model/``
  • adapt tests

@zaucker zaucker changed the title Separate GitHub repo for production models Move production models to share/ and improve naming Feb 25, 2021
@zaucker zaucker changed the title Move production models to share/ and improve naming Move production models to share/model/ and improve naming Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zaucker zaucker

Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zaucker