Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: command line parameter naming conventions #452

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: command line parameter naming conventions #452

wants to merge 1 commit into from
+10 −10

Conversation

MeenuyD
Copy link

@MeenuyD MeenuyD commented Jun 4, 2024

  • Updated all command line parameter names to use kebab-case for consistency and readability.
  • Replaced camelCase parameters with kebab-case equivalents:
    • logicalBridge to logical-bridge
    • allowMissing to allow-missing
      This change improves the readability and maintainability of the command line interface by using a consistent naming convention.
      Align cmdline parameter names cases #428

@MeenuyD MeenuyD requested a review from a team as a code owner June 4, 2024 10:24
glimchb
glimchb approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@glimchb
Copy link
Member

glimchb commented Jun 4, 2024

@MeenuyD please fix commit message according to https://commitlint.js.org/

@MeenuyD MeenuyD changed the title Align command line parameter naming conventions fix: command line parameter naming conventions Jun 4, 2024
@sandersms
Copy link
Contributor

@MeenuyD There are two checks failing, the linters check and the Commitlint. Both need to be fixed prior to merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glimchb glimchb glimchb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MeenuyD @glimchb @sandersms