Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(evpn): enable tls on godpu #447

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

atulpatel261194
Copy link
Contributor

No description provided.

@atulpatel261194 atulpatel261194 requested a review from a team as a code owner May 12, 2024 20:38
Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 5.22388% with 381 lines in your changes are missing coverage. Please review.

Project coverage is 18.53%. Comparing base (eda92b2) to head (de1bf20).
Report is 2 commits behind head on main.

Current head de1bf20 differs from pull request most recent head 0765f2d

Please upload reports for the commit 0765f2d to get more accurate results.

Files Patch % Lines
grpc/tls.go 0.00% 56 Missing ⚠️
cmd/network/evpn-logical-brige.go 0.00% 49 Missing ⚠️
cmd/network/evpn-svi.go 0.00% 47 Missing ⚠️
cmd/network/evpn-bridge-port.go 0.00% 46 Missing ⚠️
cmd/network/evpn-vrf.go 0.00% 44 Missing ⚠️
cmd/cmd.go 0.00% 24 Missing ⚠️
cmd/storage/backend/nvme_path.go 0.00% 20 Missing ⚠️
grpc/client.go 26.92% 18 Missing and 1 partial ⚠️
cmd/storage/frontend/nvme_controller.go 0.00% 15 Missing ⚠️
cmd/storage/backend/nvme_controller.go 0.00% 14 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
- Coverage   18.97%   18.53%   -0.44%     
==========================================
  Files          63       65       +2     
  Lines       10588    10870     +282     
==========================================
+ Hits         2009     2015       +6     
- Misses       8304     8569     +265     
- Partials      275      286      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one of the tests is failing

cmd/storage/frontend/nvme_controller.go Outdated Show resolved Hide resolved
grpc/client.go Outdated Show resolved Hide resolved
@atulpatel261194 atulpatel261194 force-pushed the tlsenabled branch 3 times, most recently from fdb2b35 to de1bf20 Compare May 17, 2024 17:37
cmd/cmd.go Outdated Show resolved Hide resolved
cmd/ipsec/ipsec-stats.go Outdated Show resolved Hide resolved
Signed-off-by: atulpatel261194 <[email protected]>
@atulpatel261194 atulpatel261194 force-pushed the tlsenabled branch 2 times, most recently from 0ba4dc4 to 334c849 Compare May 20, 2024 11:03
Copy link
Collaborator

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Created 2 issue for future improvements: #449 #450

@artek-koltun artek-koltun merged commit 9cf56d1 into opiproject:main May 21, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants